Repository navigation
Keep MTP sessions alive after uncorrelated JSON-RPC errors - #12283
Conversation
Accept explicit null IDs only for genuine error responses. Preserve request correlation and shutdown accounting across the platform and source-only client, with modern and Framework packaged regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧪 Test quality review — PR #12283
Compared merge base 127798de9bd5c3f7204dc8932cddf043bf4bd6c6 with head 9ab03e7774cb99667362e88e0157dc2d10e89fb1. Evidence applies to this head, not every intermediate commit. This review is static; no tests or builds were run.
Test-value evidence
| Contract | Scenario / expected outcome | Decisive test and assertion | Counterfactual | Evidence status |
|---|---|---|---|---|
A valid error with id:null is accepted as an uncorrelated ErrorMessage and its payload is preserved (both JSON engines) |
Code is -32700, -32600 or -31001. Id and StringId are null, and code, message and data are preserved. | Deserialize_NullIdError_PreservesUncorrelatedPayload: Assert.IsNull(error.Id) plus exact code, message and data assertions. |
Pre-fix strict-ID deserializer throws MessageFormatException. |
Static prediction: would be detected. The PR description reports an executed paired run (6 cases failed without the fix, passed with it). I could not access those records, so they are unverified here. |
The serializer emits an explicit "id":null |
ErrorMessage(null, ...) serializes with id present and null. |
Serialize_NullIdError_EmitsExplicitNullId: exact JSON equality. |
Reverting the (object?) cast or the nullable model would drop or break the id. |
Static prediction: would be detected. |
| Strict envelope validation is unchanged for everything else | Method or result next to a null id, malformed error or code or message, missing id on an error, null id on a success response, and null cancel id are all rejected. Correlated numeric and string ids keep their kind. | Deserialize_NullIdError_RejectsInvalidEnvelope (13 cases), Deserialize_CorrelatedError_PreservesIdKind, Deserialize_MissingErrorId_RemainsInvalid, Deserialize_NullSuccessId_RemainsInvalid, Deserialize_NullCancellationId_RemainsInvalid. |
Relaxing id handling or the envelope checks would make ThrowsExactly<MessageFormatException> fail. |
Static prediction: would be detected. |
| The server host diagnoses a null-id error without replying or leaking the shutdown request counter | Two null-id errors, then Initialize, then Exit. The server replies only once, exits 0, and logs two diagnostics, even when the logger throws. | RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts: Assert.AreEqual(0, run), Times.Once on writes, diagnostics count of 2. |
Removing the early continue would increment the request counter and hang shutdown. A Dispatch fallthrough would also change the write count. |
Static prediction: would be detected. |
| The client keeps pending requests intact (response, cancel, EOF, disposal, request id 0) | Null-id errors arrive while a request is pending. The request does not complete, and a later correlated response, cancel, disconnect or dispose still completes it correctly. | RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle (5 cases), JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero. |
Mapping a null id to 0 would complete or fail request 0: Assert.IsFalse(request.IsCompleted) would fail. |
Static prediction: would be detected. |
| End-to-end packed server and source client | Real packed server and consumer, modern TFMs and net48, survive repeated null-id frames. | Packaged acceptance tests in MtpServerClientPackagedConsumerRunTests. |
Reported as failing in the author's paired run. | Executed evidence reported by the author but not accessible to me. This workflow does not claim it. |
| Docs and schema | The null-id rule is documented and the schema is updated. | Not executable. | None. | Not applicable. Schema validation is reported by the author as executed. |
Remaining gaps: there is no accessible CI or TRX record bound to this head. The Rider and IDE recovery gap is noted by the author and not verifiable here.
🧵 Parallel safety
PARALLEL-SAFETY RESULT
STATUS: PARTIAL
The separate specialist task was not run in this execution, so parallel-safety coverage is incomplete. This is not a clean result. From the changed tests, I saw per-test state: a new FakeMtpServer, ConcurrentQueue, ServerFixture and MtpJsonRpcConnection per test, with no static or shared state added. The PR description states that no scheduling configuration changed, and no config candidates were in the manifest. Run /parallel-audit for a full assessment.
Per-test assessment
Pseudo-mutation evidence below consists of static predictions, not executed mutation results.
| Result | Quality | Test | Notes | How to improve |
|---|---|---|---|---|
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_PreservesUncorrelatedPayload |
Asserts id, code, message and data exactly for three codes. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Serialize_NullIdError_EmitsExplicitNullId |
Checks both the dictionary and the exact JSON output. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_CorrelatedError_PreservesIdKind |
Boundary ids with exact id and StringId expectations. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_RejectsInvalidEnvelope |
13 malformed envelopes, each checked against both entry points. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_MissingErrorId_RemainsInvalid |
Exact exception type for a missing id. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullSuccessId_RemainsInvalid |
Keeps the null id error-only. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullCancellationId_RemainsInvalid |
Keeps the null id out of cancellation. | None |
| Pass | A (90–100) | new ServerTestHostTests.RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts |
Checks exit code, single reply, diagnostic count and logger failure. | None |
| Pass | A (90–100) | new MtpServerClientTests.RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle |
Deterministic barrier, then each completion path asserted. | None |
| Pass | A (90–100) | new MtpServerClientTests.JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero |
Request id 0 stays pending until the correlated response. | None |
| Uncertain | — | mod MtpServerClientPackagedConsumerRunTests (packaged null-id tests and helpers) |
Acceptance tests spawn packed servers and were not graded method by method. | Supply the method bodies in scope, or run /review-tests with them. |
No inline comments are needed: no verified, actionable defect passed the publication gate. Existing review threads: none.
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~29 AIC · ⌖ ~1 AIC · ⊞ 8.1K
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues requiring changes.
No open issues 🎉
What changed in this PR
Fixes #12261 by keeping Microsoft.Testing.Platform server-mode sessions alive after valid JSON-RPC errors with an explicit null ID, without correlating them to pending requests or changing other ID rules.
Changes:
- Support uncorrelated errors in both JSON engines and the source-only client.
- Diagnose these errors without replying, completing unrelated requests, or increasing shutdown work counts.
- Update protocol documentation and add unit and packaged-consumer regression coverage, including .NET Framework.
Test-value evidence: The PR reports paired counterfactual failures and passing restored-implementation runs for revision 9ab03e7774cb99667362e88e0157dc2d10e89fb1. Execution artifacts were not independently verified here; real Rider recovery remains explicitly unverified.
| File | Description |
|---|---|
test/UnitTests/Microsoft.Testing.Platform.UnitTests/ServerMode/FormatterUtilitiesTests.cs |
Tests null-ID serialization, payload preservation, and invalid envelopes. |
test/UnitTests/Microsoft.Testing.Platform.UnitTests/Hosts/ServerTestHostTests.cs |
Tests diagnostics, logger failures, and balanced shutdown accounting. |
test/UnitTests/Microsoft.Testing.Platform.ServerMode.Client.Sources.UnitTests/MtpServerClientTests.cs |
Tests pending-request lifecycle and request-zero isolation. |
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/ServerMode/v1.0.0/TestingPlatformClient.cs |
Adds literal error-frame injection and process-output access. |
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/ServerMode/ServerModeTestsBase.cs |
Supports additional fixtures, captures output, and stops listeners. |
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/MtpServerClientPackagedConsumerRunTests.cs |
Adds packaged client/server regressions and binary-provenance checks. |
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.RpcMessageSerializers.cs |
Preserves explicit null IDs in dictionary serialization. |
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/SerializerUtilities.Deserializers.cs |
Accepts null-ID errors while validating their envelopes. |
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/RpcMessages.cs |
Makes the error-message ID nullable. |
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Serializers.cs |
Emits null error IDs in the modern JSON engine. |
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Json.Deserializers.cs |
Adds modern-engine parsing and validation for uncorrelated errors. |
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt |
Records nullable internal error-message signatures. |
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.MessageLoop.cs |
Diagnoses uncorrelated errors before request accounting. |
src/Platform/Microsoft.Testing.Platform.ServerMode.Client.Sources/Client/SerializerUtilities.ClientSerializers.cs |
Routes null-ID errors through client deserialization. |
src/Platform/Microsoft.Testing.Platform.ServerMode.Client.Sources/Client/MtpJsonRpcConnection.cs |
Logs uncorrelated errors without completing pending requests. |
docs/mstest-runner-protocol/server-mode-1.0.schema.json |
Allows null error IDs and excludes conflicting result payloads. |
docs/mstest-runner-protocol/001-protocol-intro.md |
Documents uncorrelated errors and recovery limitations. |
Review effort: Balanced
Address review feedback while preserving separate ID-presence, null-value, and exact JSON output checks. No product behavior changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧪 Test quality review — PR #12283
Compared merge base 127798de9bd5c3f7204dc8932cddf043bf4bd6c6 with head efa13856c4dcdde6891fe844790f2d20c26aa1c8. Evidence applies to this head, not every intermediate commit. This review is static; no tests or builds were run. The only change since the previous review (9ab03e77) is a two-line lookup tweak in FormatterUtilitiesTests.
Test-value evidence
| Contract | Decisive test and assertion | Counterfactual | Evidence status |
|---|---|---|---|
A null-id error is accepted as an uncorrelated ErrorMessage and keeps its payload (both JSON engines) |
Deserialize_NullIdError_PreservesUncorrelatedPayload: Assert.IsNull(error.Id) plus exact code, message and data |
The pre-fix strict-id deserializer throws MessageFormatException |
Static prediction: detected. The author reports an executed pair at 9ab03e77, but I could not access those records, so it is unverified here. |
The serializer emits an explicit "id":null |
Serialize_NullIdError_EmitsExplicitNullId: exact JSON equality |
Reverting the (object?) cast or the nullable model drops or breaks the id |
Static prediction: detected |
| Envelope validation is otherwise unchanged | Deserialize_NullIdError_RejectsInvalidEnvelope (13 cases), Deserialize_CorrelatedError_PreservesIdKind, Deserialize_MissingErrorId_RemainsInvalid, Deserialize_NullSuccessId_RemainsInvalid, Deserialize_NullCancellationId_RemainsInvalid |
Relaxing the id or envelope checks fails ThrowsExactly<MessageFormatException> |
Static prediction: detected |
| The host diagnoses a null-id error without replying or leaking the request counter | RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts: exit 0, a single write, 2 diagnostics, with and without a throwing logger |
Removing the early continue increments the counter and hangs shutdown |
Static prediction: detected |
| The client keeps pending requests intact (response, cancel, EOF, dispose, id 0) | RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle (5 cases), JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero |
Mapping a null id to 0 completes request 0, so Assert.IsFalse(request.IsCompleted) fails |
Static prediction: detected |
| End-to-end packed server and source client | The packaged tests in MtpServerClientPackagedConsumerRunTests |
The author reports they failed without the fix | Reported by the author only; no accessible record is bound to this head |
| Docs and schema | Not executable | None | Not applicable |
Remaining gap: no CI or TRX record is accessible for this head, and Rider recovery is unverified (the author notes it as a gap).
🧵 Parallel safety
STATUS: CLEAN. No findings (Critical 0, High 0, Warning 0, Info 0). The parallel-safety specialist's coverage was read-only, and it did not verify the worker count or scheduling attributes.
| Test assembly | Scope |
|---|---|
| Microsoft.Testing.Platform.Acceptance.IntegrationTests | Method-level; no opt-out attribute |
| Microsoft.Testing.Platform.UnitTests and ServerMode.Client.Sources.UnitTests | Changed unit tests |
No parallelization configuration changed. The new tests use per-test fixtures and distinct asset names (-null-error-{tfm}), and add no static mutable state.
Per-test assessment
Pseudo-mutation evidence consists of static predictions, not executed mutation results.
| Result | Quality | Test | Notes | How to improve |
|---|---|---|---|---|
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_PreservesUncorrelatedPayload |
Asserts id, code, message and data exactly for three codes. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Serialize_NullIdError_EmitsExplicitNullId |
Checks both the dictionary and the exact JSON. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_CorrelatedError_PreservesIdKind |
Boundary ids with exact id and StringId expectations. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_RejectsInvalidEnvelope |
13 malformed envelopes, each checked against both entry points. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_MissingErrorId_RemainsInvalid |
Exact exception type for a missing id. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullSuccessId_RemainsInvalid |
Keeps the null id error-only. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullCancellationId_RemainsInvalid |
Keeps the null id out of cancellation. | None |
| Pass | A (90–100) | new ServerTestHostTests.RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts |
Checks exit code, single reply, diagnostic count and logger failure. | None |
| Pass | A (90–100) | new MtpServerClientTests.RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle |
A deterministic barrier, then each completion path is asserted. | None |
| Pass | A (90–100) | new MtpServerClientTests.JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero |
Request id 0 stays pending until the correlated response. | None |
| Uncertain | — | mod MtpServerClientPackagedConsumerRunTests (packaged null-id tests and helpers) |
The process-spawning acceptance tests were not graded method by method. | Supply the method bodies in scope, or re-run /review-tests with them. |
No inline comments: no verified, actionable defect passed the publication gate. No live review threads exist on this PR.
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~63 AIC · ⌖ ~1 AIC · ⊞ 8.1K
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use the existing MTP_CLIENT_USE_MODERN_DOTNET package flag instead of NETCOREAPP in the generated null-error probe. Add a cross-platform net6 consumer case so the Jsonite fallback is exercised even when Unix execute-permission tests are unavailable. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🧪 Test quality review — PR #12283
Compared merge base 127798de9bd5c3f7204dc8932cddf043bf4bd6c6 with head 11238b81d96408ae11646989250344ff8943ff43. Evidence applies to this head, not every intermediate commit.
Test-value evidence
All entries are static predictions. No paired execution records were available, and this workflow does not run tests.
| Contract | Scenario and expected outcome | Test and decisive assertion | Counterfactual | Evidence |
|---|---|---|---|---|
| Null-id error deserialization (both serializers, client and server) | {"id":null,"error":{...}} yields an ErrorMessage with Id == null and the payload preserved. |
FormatterUtilitiesTests.Deserialize_NullIdError_PreservesUncorrelatedPayload; Assert.IsNull(error.Id) |
The old code requires a non-null id and throws. | Static prediction: detected. |
| Invalid null-id envelopes rejected | result/method present, or a malformed error.code/error.message, throws MessageFormatException. |
Deserialize_NullIdError_RejectsInvalidEnvelope (13 cases); ThrowsExactly<MessageFormatException> |
Dropping the validation would accept these envelopes. | Static prediction: detected. |
| A missing id stays invalid, and correlated int/string id kinds are preserved. | A missing id throws. Int and string ids keep their kind. | Deserialize_MissingErrorId_RemainsInvalid, Deserialize_CorrelatedError_PreservesIdKind |
Treating an absent id as null would break the first. Conflating id kinds would break the second. | Static prediction: detected. |
Null id serialized as an explicit null |
The serialized JSON contains "id":null. |
Serialize_NullIdError_EmitsExplicitNullId; exact JSON equality |
Omitting the id or using 0 fails the assertion. |
Static prediction: detected. |
| Server ignores uncorrelated errors | Two null-id errors do not complete or leak request counts, the initialize response is written once, and the diagnostics are logged. This holds with a failing logger too. | ServerTestHostTests.RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts; diagnostics == 2, WriteRequestAsync Times.Once |
Without the guard, _requestCounter.AddCount() runs and the error is routed as id 0. |
Static prediction: detected. |
| Client keeps pending requests alive | A null-id error must not complete request id 0 or any pending run. | MtpServerClientTests.JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero; request.IsCompleted is false and the pending count is 1 |
The old code mapped a null id to 0 and would fail the request. | Static prediction: detected. |
| Client run lifecycle with null-id errors | The run stays pending, then ends normally by response, cancellation, disconnect or disposal. | RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle (5 cases) |
The same as the entry above. | Static prediction: detected. |
| Docs, schema and acceptance consumers | These are non-executable or integration-level changes. | MtpServerClientPackagedConsumerRunTests, ServerModeTestsBase and TestingPlatformClient were not traced in depth. |
n/a | Docs and schema: not applicable. Acceptance coverage: unverified. |
🧵 Parallel safety
STATUS: CLEAN. The specialist's pass over the diff found no new shared static state, ports or environment mutation. The packaged-consumer tests use uniquely named assets. This was a read-only diff review, and parallelization settings were not determined. No findings.
Per-test assessment
Pseudo-mutation evidence below consists of static predictions, not executed mutation results. Production context was resolved from the diff, and the test-gap-analysis and grade-tests skill workflows were not run in full, so this scorecard is a manual assessment. The acceptance-test helper changes were not graded in detail.
| Result | Quality | Test | Notes | How to improve |
|---|---|---|---|---|
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_PreservesUncorrelatedPayload |
Asserts every field of the preserved payload. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_NullIdError_RejectsInvalidEnvelope |
13 cases, each exercised through two entry points. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Serialize_NullIdError_EmitsExplicitNullId |
Checks both the property dictionary and the exact JSON. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_CorrelatedError_PreservesIdKind |
Boundary ids cover both id kinds. | None |
| Pass | A (90–100) | new FormatterUtilitiesTests.Deserialize_MissingErrorId_RemainsInvalid |
Pins the negative contract. | None |
| Pass | A (90–100) | new ServerTestHostTests.RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCounts |
Uses barriers and a failing-logger case, with no wall-clock assertions. | None |
| Pass | A (90–100) | new MtpServerClientTests.RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle |
Deterministic barrier, five lifecycle paths. | None |
| Pass | B (80–89) | new MtpServerClientTests.JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero |
Reflection on the private _nextRequestId couples it to the field name. |
None |
No inline comments were published. Existing-thread deduplication was not needed, since no inline candidates passed the publication gate.
<sub>This advisory review is heuristic and non-blocking.
Re-run the combined review with /review-tests, or only the parallel-safety specialist with /parallel-audit.</sub>
🤖 Automated content by GitHub Copilot. Generated by the Test Quality Review on PR (on open / sync) workflow. · copilot · auto · ~54 AIC · ⌖ ~1 AIC · ⊞ 8.1K
|
Preliminary test-triage analysis — Azure Pipelines build 1671113 Triggering check: Failure signature
Assessment
Next step
|
Pull request
Summary
Keep Microsoft.Testing.Platform server-mode sessions alive when a peer sends a valid JSON-RPC error response with an explicit null ID. Fixes #12261.
The error model, both JSON engines, the separately shipped source-only client, and the protocol schema now distinguish an uncorrelated error from a missing or invalid ID. Such errors are diagnosed without replying, completing an unrelated request, or adding work to the host's shutdown counter. Normal numeric/canonical-string request, response, and cancellation IDs retain their existing behavior.
This does not recover Rider's lost messages, change UTF-8 framing, or implement general malformed-message recovery. A servicing backport is being prepared for
rel/4.5/ MTP 2.5.3.Design and decision record
The issue investigation and scoped decision is the maintained rationale for this bug fix; no new feature/design document is necessary. JSON-RPC 2.0 section 5 requires null when the request ID cannot be determined.
Independent GPT-6.1 Sol and Claude Sonnet 5 plan reviews agreed on the narrow fix, with safeguards incorporated here: error-only null support, strict null-error envelopes, balanced shutdown accounting, no guessed request correlation, and real packaged modern/Framework coverage. We deliberately did not relax shared ID helpers, introduce capabilities/public APIs/timeouts, or promise stream resynchronization.
Demonstration
The previously reproduced shipping MTP 2.5.2
net48sequence was:The actual packed-server regressions now send the same literal frame repeatedly between completed RPC requests, discover exactly one action node (
uid=TestMethod1,display-name=TestMethod1, statediscovered), execute that same node with statepassed, and verify server exit 0. They compare the executed DLL bytes to the selected fresh NuGet asset and verify the server's reported loaded assembly path. The packed source-client consumers also decode the literal null-ID error before launching and driving a real server.This is a nonvisual protocol change, so a readable sequence and executable assertions are more useful than screenshots. Rider itself and its reported Unicode parser failure were not available for capture; IDE recovery remains unverified, not implied by the passing wire tests.
Validation and regression proof
Revision:
9ab03e7774cb99667362e88e0157dc2d10e89fb1, based on127798de9bd5c3f7204dc8932cddf043bf4bd6c6. The initial full-pack/18-case run used the identical source as that base plus patch SHA-256F576DC76E121E2F87E96432F662AB59DD9825A4DFFF1CBF8CA7676BF4727CF39; the paired restored-implementation runs rebuilt and repacked the committed revision itself.Toolchain: repository-pinned .NET SDK
12.0.100-alpha.1.26509.101; Debug configuration. Unit engines ran onnet10.0,net11.0, and Windowsnet462(Jsonite). The outer acceptance host wasnet12.0; generated shipping consumers exercisednet10.0,net11.0, and Windowsnet48, including the packed C# 12/down-level source slice. The full Windows pack used the repository's desktop MSBuild path because MSTest's UAP support requires it.The following are the executed command shapes;
$evidenceDirand$resultswere task-owned, separate directories, with unique binary-log names retained for every build/test/pack:net10.0/net11.0/net462net10.0/net11.0/net462verify_execution.pyon the acceptance TRX and source/discovery-derived expected namesjsonschema.Draft202012ValidatorRequirement coverage
Deserialize_NullIdError_PreservesUncorrelatedPayload,Serialize_NullIdError_EmitsExplicitNullId; both engines.Deserialize_NullIdError_RejectsInvalidEnvelope,Deserialize_CorrelatedError_PreservesIdKind,Deserialize_MissingErrorId_RemainsInvalid,Deserialize_NullSuccessId_RemainsInvalid,Deserialize_NullCancellationId_RemainsInvalid, existingNullRequestId_IsRejected.RunAsync_NullIdErrorsAreDiagnosedWithoutLeakingRequestCountswith normal and throwing loggers.RunTestsAsync_NullIdErrors_PreservePendingRequestLifecycle,JsonRpcConnection_NullIdError_DoesNotCompleteRequestZero.PackagedServer_NullIdErrorsPreserveDiscoveryExecutionAndExiton both modern TFMs;PackagedFrameworkServer_NullIdErrorsPreserveDiscoveryExecutionAndExitonnet48.PackagedConsumer_LaunchesRealServer_DiscoversAndRunsExpectedNode,PackagedFrameworkConsumer_NullIdErrorIsAcceptedAndRealServerRemainsUsable,HostileConsumer_CompilesAgainstPackedSource, and all selected source-package anti-drift guards.The test assemblies retain method-level scheduling. New mutable state, loopback peers, generated assets, and source-consumer caches are per test; no assembly opt-in/opt-out or global test lock was changed. Windows release CI selects the ordinary solution tests when
SkipTestsis false; live CI execution is not claimed by local validation.Test-value evidence
Executed: detected. In a separate, task-owned sibling worktree, only the two error deserializers were restored to their pre-fix strict-ID behavior from
127798de9bd5c3f7204dc8932cddf043bf4bd6c6. The nullable model/API, writers, dispatch safeguards, test code, assertions, scheduling, and selection were retained. This is a buildable targeted counterfactual, not a pristine baseline.Counterfactual patch SHA-256:
4BC19D9A3E4FF3C185982BF2A72E1CF5C4E7B0979F8737E6B45B1230B5878CB5. Both variants were rebuilt/repacked separately and generated consumers restored into fresh caches.Deserialize_NullIdError_PreservesUncorrelatedPayloadnet10.0and 3 onnet462executed/failed with the intendedMessageFormatException; test exits 2.9ab03e7774cb99667362e88e0157dc2d10e89fb1; outer exit 0, fresh TRX identity/count gate passed.Paired selectors were
FullyQualifiedName~Deserialize_NullIdError_PreservesUncorrelatedPayloadandFullyQualifiedName~MtpServerClientPackagedConsumerRunTests&FullyQualifiedName!~PackagedNet6. The isolated source was restored clean afterwards. Retained evidence includes TRX/JUnit/CTRF results, unique binlogs, source/counterfactual patches, package hashes, and resolved/loaded asset paths. Local artifact paths are intentionally not presented as publicly accessible CI links.Remaining gap: no real Rider installation/traffic capture or IDE rendering/recovery validation. General malformed framing remains outside this PR.